[JDocumentRendererHtmlHead] only add the type attribute in the new script options if it's not an html5 page#10632
Closed
andrepereiradasilva wants to merge 1 commit intojoomla:stagingfrom
Closed
Conversation
…l5 template (like doen for the rest of js/css already)
Contributor
|
I have tested this item ✅ successfully on b4d0025 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10632. |
|
I have tested this item ✅ successfully on b4d0025 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10632. |
Contributor
|
rtc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10632. |
Contributor
|
This has been rewritten in 3.7.x with #11671 - so this is no longer relevent I'm afraid. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
#9843 removed all the
typeattributes in html5 pages if they are the default html5 types for js/css.But #3072 added a new script options render to JDocument renderer for HTML head.
For consistency, this simple PR does the same for the new script options.
Testing Instructions
Very simple PR. Code review.
Or ... you can follow the same test instructions as #9843 and #3072.