Skip to content

Conversation

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented May 8, 2016

Pull Request for New Issue.

Summary of Changes

com_finder is missing in com_admin script.php.
This PR adds it.

Testing Instructions

Code review.

@andrepereiradasilva
Copy link
Contributor Author

BTW, com_joomlaupdate is missing to.
@wilsonge

@zero-24
Copy link
Contributor

zero-24 commented May 8, 2016

Good find. Can you add com_joomlaupdate as well to the PR?

@andrepereiradasilva
Copy link
Contributor Author

ok @zero-24 added it.
Did not added before because not sure it should be added here, that's why i pinged @wilsonge

@zero-24
Copy link
Contributor

zero-24 commented May 8, 2016

Easy fix. Thanks -> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10300.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2016
@zero-24
Copy link
Contributor

zero-24 commented May 8, 2016

I have tested this item ✅ successfully on 68b3124

👍


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10300.

@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 8, 2016
@wilsonge wilsonge merged commit 5318a16 into joomla:staging May 8, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 8, 2016
@andrepereiradasilva
Copy link
Contributor Author

thanks for testing, comments and merging!

@andrepereiradasilva andrepereiradasilva deleted the patch-9 branch May 8, 2016 11:02
roland-d added a commit to roland-d/joomla-cms that referenced this pull request May 8, 2016
…leanup-installer-plugins

* 'staging' of https://github.com/joomla/joomla-cms:
  Add missing com_finder to com_admin script php (joomla#10300)
  Add missing slash
  Removed redundant else statemetn from JFormHelper::loadType (joomla#7979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants