[5.1] abandoned composer dependencies

[heelc29]

After #42945 merged, there are many "abandoned" warnings during composer install @laoneo @LadySolveig

https://ci.joomla.org/joomla/joomla-cms/74324/1/6

[richard67]

Maybe it just needs to change this line https://github.com/joomla/joomla-cms/blob/5.1-dev/composer.json#L105
from "web-token/signature-pack": "^3.2.10",
to "web-token/jwt-library": "^3.3.1",?

[heelc29]

Maybe it just needs to change this line https://github.com/joomla/joomla-cms/blob/5.1-dev/composer.json#L105 from "web-token/signature-pack": "^3.2.10", to "web-token/jwt-library": "^3.3.1"?

I just tried it 5 minutes ago 😅

[richard67]

Hmm, yes, seems not to help.

Maybe we can't really avoid that because it's caused by that library's composer.json files?

[heelc29]

Hmm, yes, seems not to help.

Maybe we can't really avoid that because it's caused by that library's composer.json files?

It works ... there is no longer a warning

[richard67]

Hmm, yes, seems not to help.
Maybe we can't really avoid that because it's caused by that library's composer.json files?

It works ... there is no longer a warning

@heelc29 What did you change? I changed line 105 in the composer.json from "web-token/signature-pack": "^3.2.10", to "web-token/jwt-library": "^3.3.1", but that did not help here. If you have a fix: Could you make a PR?

[richard67]

Hmm, I did now run a composer update web-token/jwt-library in addition to the mentioned change, and that seems to fix it.

[richard67]

I will make a PR in a few minutes.

[richard67]

@heelc29 I see you already created one ... would have been helpful to mention that here and to close this issue like we do it when we have a PR for it.

[richard67]

Closing as having a pull request. See #42954 .

[heelc29]

@heelc29 I see you already created one ... would have been helpful to mention that here and to close this issue like we do it when we have a PR for it.

Was not sure if its the "right" fix...

[richard67]

I wasn't sure either, but if it is ok it will also need my follow up PR #42955 .