[5.0.1-rc1][UX] TinyMCE builder is always displayed with dark skin

[heelc29]

Steps to reproduce the issue

disable darkmode
open options of TinyMCE plugin

Expected result

TinyMCE is display with light skin

Actual result

TinyMCE is displayed with dark skin

Additional comments

behavior change with #42322 @wilsonge

[bembelimen]

Hi @heelc29 ,
did you switch after you called the editor in dark or before you entered the backend?

[brianteeman]

#42322

Unlike the template which will actually flick over immediately once the OS is changed this will not change until the page is next reloaded.

[bembelimen]

Ahh, sorry, found it now.

[Fedik]

That happen because oxide-dark/skin.min.css override oxide/skin.min.css:

joomla-cms/layouts/plugins/editors/tinymce/field/tinymcebuilder.php

Lines 64 to 65 in 43a9aab

	$wa->registerAndUseStyle('tinymce.skin', 'media/vendor/tinymce/skins/ui/oxide/skin.min.css')
	->registerAndUseStyle('tinymce.skin.dark', 'media/vendor/tinymce/skins/ui/oxide-dark/skin.min.css')

The builder does not use any code to manage tinymce styles, it added directly to document.

[wilsonge]

Yeah we can revert that line I guess. I'd forgotten totally about the tinymce builder. It's not tinymce in anyway - just custom divs and styling to mimic it. So unless we conditionally load the css files in javascript and break CSP we're kinda screwed whatever happens I guess (maybe we can template override - but seems like kinda overkill?)

[Fedik]

I have reverted it for now, please test #42392

[brianteeman]

sorry - i missed that this was the plugin setup page