[4.0] webcomponents debug

[brianteeman]

Normally when joomla debug mode is on we use the non minified assets

But that is not true for "some" of the js in the system/webcomponents/js and vendor/webcomponents/js folders

Screenshot of global config showing just some are non minified

[dgrammatiko]

@brianteeman check for example rules.php under layouts/joomla/form:

HTMLHelper::_('webcomponent', 'system/webcomponents/joomla-field-permissions.min.js', ['version' => 'auto', 'relative' => true]);
HTMLHelper::_('webcomponent', 'vendor/joomla-custom-elements/joomla-tab.min.js', ['relative' => true, 'version' => 'auto']);

there is a missing flag 'detectDebug' => true

[brianteeman]

Thanks for the pointer. I can fix that on the train to the presentation

[brianteeman]

or maybe not

A quick search shows these three variations - is there some logic behind the differences?

HTMLHelper::_('webcomponent', 'vendor/joomla-custom-elements/joomla-alert.min.js', ['relative' => true, 'version' => 'auto']);
HTMLHelper::_('webcomponent', 'vendor/joomla-custom-elements/joomla-alert.min.js', ['relative' => true, 'version' => 'auto', 'detectBrowser' => false, 'detectDebug' => false]);
HTMLHelper::_('webcomponent', 'system/webcomponents/joomla-field-media.min.js', ['relative' => true, 'version' => 'auto', 'detectBrowser' => false, 'detectDebug' => true]);

[dgrammatiko]

Tha last one should be the norm...

[Bakual]

Would it make sense to add those as default values to the HtmlHelper method? If not needed it could be explicitely disabled instead of us having to explicitely add it everywhere.

[brianteeman]

Would save a massive search and replace and ofc no guarantee it wouldn't happen again

[Bakual]

On a fast glance there is actually a default defineed. It's just false. If we change that to true we could save quite a bit of code. Also the relative and detectBrowser would already be covered.
See

joomla-cms/libraries/src/HTML/HTMLHelper.php

Lines 843 to 845 in 1daaaac

	$options['relative'] ?? true,
	$options['detectBrowser'] ?? false,
	$options['detectDebug'] ?? false

[C-Lodder]

Is detectDebug the boolean that will ensure the uncompressed version of the file is loaded when debug mode is enabled?

[brianteeman]

yes

[C-Lodder]

Why does that need to be a function arguement?

[dgrammatiko]

it's there for B/C

[mbabker]

It has use in some edge cases. I have extensions where I'm pulling a vendor CSS or JS file and not including both a minified and unminified version of it, so I can tell Joomla to save a few CPU cycles and skip deciding if debug mode is enabled and trying to scan the filesystem for variants that will never exist (same for the detectBrowser option).

[Bakual]

it's there for B/C

B/C for a method which is completely new in 4.0.0? Probably not.

In the other similar methods for scripts and stylesheets, detectDebug already defauls to true, so I'd say it's save to change that behavior for the new method so it follows the other behaviors.

See #21617