Staging: Multilingual Menus with Home Page have lost their icons

[infograf768]

Steps to reproduce the issue

Create a multingual site with staging

Expected result (test on a 3.7.4)

Actual result (on staging)

@izharaazmi
Could it be a consequence of one of your PRs?

[izharaazmi]

Not sure but as I remember, I didn't add support for icons display yet. This can be added now.

[infograf768]

This is what we had before in enabled:

if ($menuType->home == 0)
		{
			$titleicon = '';
		}
		elseif ($menuType->home == 1 && $menuType->language == '*')
		{
			$titleicon = ' <span class="icon-home" aria-hidden="true"></span>';
		}
		elseif ($menuType->home > 1)
		{
			$titleicon = ' <span>'
				. JHtml::_('image', 'mod_languages/icon-16-language.png', $menuType->home, array('title' => JText::_('MOD_MENU_HOME_MULTIPLE')), true)
				. '</span>';
		}
		elseif ($menuType->image && JHtml::_('image', 'mod_languages/' . $menuType->image . '.gif', null, null, true, true))
		{
			$titleicon = ' <span>' .
				JHtml::_('image', 'mod_languages/' . $menuType->image . '.gif', $alt, array('title' => $menuType->title_native), true) . '</span>';
		}
		else
		{
			$titleicon = ' <span class="label" title="' . $menuType->title_native . '">' . $menuType->sef . '</span>';
		}

[izharaazmi]

Well okay. I'll try to look into it this weekend.

[infograf768]

@izharaazmi

We really can't release 3.8 with this bug.
Honestly I prefer reverting #16451 than go without the flags.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17406.}

[izharaazmi]

Sorry. I'll look at this today.

[izharaazmi]

@infograf768 I have done the fixes. I was trying to test with multiple menu items but stuck. I am not able to create default menu item for different languages. I tried looking at the code but I don't understand it at – libraries/src/Table/Menu.php:236 The entire if block (if ($this->home == '1')) does not look like doing what it says. Can you please look and confirm. Also please advise if I might be missing on something with multilingual menu homes.

[infograf768]

Closing as we have a patch
#17511