Array to string conversion in /var/www/js/administrator/modules/mod_menu/menu.php 613

[VampiRUS]

Steps to reproduce the issue

Component has submenu item with filter option:

<submenu>
	<menu link="option=com_plugins&amp;view=plugins&amp;filter[search]=search"
		view="plugins" img="class:plugin" alt="Plugins">com_component_plugins</menu>
</submenu>

Expected result

Actual result

Error notice in admin panel:
Notice: Array to string conversion in /var/www/js/administrator/modules/mod_menu/menu.php on line 613

System information (as much as possible)

Joomla 3.7.3

Additional comments

[zero-24]

Please tell us the exact PHP Version. As $parts should be an array and impode is constructed to move arrays to strings. I'm a bit confused.

[VampiRUS]

php 5.5.9
if $link = "index.php?option=com_plugins&view=plugins&filter[search]=search";
$uri->getQuery(true);
will return

array (
   'option' => 'com_plugins',
   'view' => 'plugins',
   'filter' =>
   array (
   'search' => 'search',
   ),
   )

[eshiol]

The issue is in administrator/modules/mod_menu/menu.php on line 610

				$parts[] = str_replace(array('.', '_'), '-', $value);

Try to replace it with

				if (!is_array($value))
				{
					$parts[] = str_replace(array('.', '_'), '-', $value);
				}
				else
				{
					foreach ($value as $k => $v)
					{
						$parts[] = $k.'-'.str_replace(array('.', '_'), '-', $v);
					}
				}

@VampiRUS have you tried above Suggestion?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17128.}

[VampiRUS]

@franz-wohlkoenig yes it helps

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17128.}

@VampiRUS as Issue is resolved can you please close the Issue?

[VampiRUS]

@franz-wohlkoenig this is issue in joomla code, i think it must be fixed there.

@maintainers any Opinion?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17128.}

[zero-24]

@franz-wohlkoenig just FYI you can't tag @maintainers you just tag this org: https://github.com/maintainers ;)

Regarding the topic what about doing the suggested code changes as PR so we can test and merge the fix?

@zero-24 will try to remember :-)

[mbabker]

I don't remember what the permissions are on GitHub but you can try pinging @joomla/cms-maintainers

[zero-24]

IMO you need to be part of that team or owner to be allowed to ping the team ;)

[mbabker]

I don't remember what the permissions are on who can ping teams or who is in what team off the top of my head. If the feature works for him then cool, if not, well, blame GitHub 😉

pinging https://github.com/maintainers & @joomla/cms-maintainers

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17128.}