Changes to JInput getString cause issues

[joeforjoomla]

Steps to reproduce the issue

Changes to the cleanTags method in root/libraries/joomla/filter/input.php
causes issues when using:
$input->getString() method.

Some characters such as < and > are not passing anymore getting stripped out

This should be at least documented somewhere, if the getString result is now different than before.

Expected result

string>passed>ok

Actual result

stringpassedok

System information (as much as possible)

Additional comments

[joeforjoomla]

And more importantly: how can i get a string like 'string>passed>ok' using JInput if getString is no more usable?

[joeforjoomla]

This could lead to unexpected results because characters '<' and '>' included in a string can't get saved anymore when using getString().

[mbabker]

Looking at the last changes in JFilterInput, this case works fine at 685f55e but is broken at 495dcc7

Unless there is some necessity for the added filtering, this is not only a bug, but a release blocker.

// @rdeutz

[joeforjoomla]

We have experimented issues especially when using getString for tokens such as OAuth, etc
If the string contains a '>' or '<' now it gets stripped out and things don't work anymore.

But obviously this impacts everywhere, even when saving an article title or 'Meta description' field.

[wojsmol]

@csthomas Plese check this also.

[joeforjoomla]

Merge this issue to the 3.7.3 branch please.

[rdeutz]

@joeforjoomla only PR can be based on a branch. I have created unit tests so that we can see we a code change passes. #16816

[joeforjoomla]

Thanks @rdeutz ... sorry for my ignorance

[rdeutz]

All good we all are learning constantly :-)

[joeforjoomla]

:) that's true

[wilsonge]

Did all these cases pass before? Like I'm pretty sure that one of these cases is a "known failure" for ages (see my 18 month old issue at joomla-framework/filter#15)

[rdeutz]

If I revert 495dcc7 a string like "string>passed>ok" is working fine, with my added test cases we have 28 errors without revert and 21 after revert.