Sampledata: Separate Metismenu, use real names for menu items#96
Sampledata: Separate Metismenu, use real names for menu items#96richard67 merged 11 commits intodevelopmentfrom
Conversation
|
speaking names ?? |
chmst
changed the title
|
Other than lorem ipsum .. it is too late for correct English :) |
|
I knew it was a lost in translation problem I just couldnt work it out. "real words" would probably be correct ;) |
chmst
changed the title
|
@chmst Not sure if I'm available to do a complete review. But what I've noticed is that the title "Metismenu" might be misleading. It makes me expect to find some information about Metismenu below it (whatever that may be, a non dev user might think). But that's not the case. |
|
@chmst Is it by purpose that now the metismenu doesn't have anymore a parent item which has a link plus a dropdown toggle and again only have menu items of type "heading" as parent items? |
…u, use layout noCard for newsflash
|
@richard67 with these changes your RFC 104 is resolved. Our sample articles arenot good for masonry layout. |
|
@chmst What still confused me is that for 2 of 3 menu items in the pull down in the 3rd level, the titles and the corresponding article titles are different.
Another thing is that I'm not sure if we use the format "Joomla V4" anywhere in our publications. I remember only having seen "Joomla 4", "Joomla V4" I don't remember having seen it anywhere in official publications. But with this I might be wrong, my memory is good but not perfect. |
|
The Category List is dammaged: https://issues.joomla.org/tracker/joomla-cms/29504 |
I guess that's not related to my previous comment, or is it? I was referring to the single article links on the 3rd level of the pulldown menu. |
|
@thank you.
No, it is not. is is referred to |
|
Thank you @richard67 I have changed the Item Menu names so that is is clearer. |
|
@chmst When having set up a multilingual site, logging in with English backend language, installing blog sample data, loggin out from backend and in again with German language and installing blog sample data, step 1 fails with the error that a category has the same alias as another category within the same parent category. That was not the case when I've tested that with the development branch a while ago. |
|
aslo = also |
|
@richard67 have you installed a multilingual site? As language files in DE and EN have the same content, the category names indeed are duplicates. |
@chmst Yes, I have installed a multilingual site. The titles of other stuff is extended by the language code in brackets. It should be done the same way for categories. |
|
I don't know why, but the category title "Joomla 4" cannot be used and results in errors. This needs investigation in the category model. For now I have changed "Joomla 4" to "Joomla" |
|
I have tested this PR ✅ with success. |
3 participants
Summary of Changes
The intention of this PR is to make a separate Metismenu, with real words in Menu Items.
It lets the old menu Items untouched and makes testing easier for rtl by @infograf768.
Additionally some houskeeping was made, typos fixed, hard coded item_ids replaced by the correct ItemIds.
Testing Instructions
Install blog sample data in a fresh installation
Expected result
The menu with metismenu looks like this, all links are correct.
Actual result
Note
While working here I have found some other issues:
#95 , #97, #98
In sampleData the module chrome noCard is used for the newsflash module. If chromeNames are changed, this has to be updated