This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Cassiopeia/adjust toggle google font#62
Closed
hans2103 wants to merge 2 commits intojoomla:developmentfrom
hans2103:cassiopeia/adjust-toggle-google-font
Closed
Cassiopeia/adjust toggle google font#62hans2103 wants to merge 2 commits intojoomla:developmentfrom hans2103:cassiopeia/adjust-toggle-google-font
hans2103 wants to merge 2 commits intojoomla:developmentfrom
hans2103:cassiopeia/adjust-toggle-google-font
Conversation
brianteeman
reviewed
Sep 7, 2020
| TPL_CASSIOPEIA_FONT_LABEL="Google font for text and headings" | ||
| TPL_CASSIOPEIA_FONT_DESC="Load Google font for text and headings (H1, H2, H3, etc)." | ||
| TPL_CASSIOPEIA_FONT_NAME_LABEL="Google Font Name" | ||
| TPL_CASSIOPEIA_FONT_LABEL="Google Fonts or Text and Headings" |
Contributor
There was a problem hiding this comment.
Did you mean to change "for" to "or" ?
Contributor
|
Please alpha sort the language strings |
Collaborator
Author
|
Closing this PR since this Switcher will not make it to Joomla4. It is for development purposes only |
Member
|
See PR #61 for the removal of the switcher and change of language strings and more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Current implementation to toggle the use of Google Fonts differs from the other toggles on tab Advanced of the Cassiopeia template. This PR solves this by adjusting the field parameters.
Testing Instructions
Expected result
Actual result
Documentation Changes Required