Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

4.0 dev relative sizes#38

Closed
hans2103 wants to merge 10 commits into4.0-devfrom
4.0-dev-relative-sizes
Closed

4.0 dev relative sizes#38
hans2103 wants to merge 10 commits into4.0-devfrom
4.0-dev-relative-sizes

Conversation

@hans2103
Copy link
Collaborator

Pull Request for Issue # .

Summary of Changes

This PR will make the Cassiopeia more a11y by replacing sizes set in px by relative sizes like em and rem.
An interesting blog explaining why we have to do this can be written on 24a11y.com => https://www.24a11y.com/2019/pixels-vs-relative-units-in-css-why-its-still-a-big-deal/

Testing Instructions

  • open Joomla 4 test and inspect elements... font-size, breakpoints and site--grid are set in PX
  • open browser settings and increase default font-size.
  • see result
  • open browser settings and set default font-size back to normal
  • apply PR and run npm run build:css
  • open Joomla 4 test and inspect elements... font-size, breakpoints and site--grid are set in EM
  • open browser settings and increase default font-size.
  • see result

If all sizes are set in relative sizes the website grows equally when default font-size is enlarged or reduced

@richard67
Copy link
Member

The changes in this PR have been integrated into #41 .

@richard67 richard67 closed this Aug 27, 2020
@richard67 richard67 deleted the 4.0-dev-relative-sizes branch August 27, 2020 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments