Cassiopeia/tags x and font size#250
Conversation
|
I've just tested. Before applying PR, issue with Category "x" button see red mark: After applying PR with a tag with some letter in name which goes below the base line, i.e. g, j, q, y: @hans2103 @chmst @drmenzelit What do you think? |
|
@hans2103 Still a bit too little padding at top and bottom of the text, for my taste. |
|
@hans2103 There is still some RTL missing. Note the difference between the 2 screenshots regarding the space between the "X" and the vertical line which separates it from the tag title: |
|
@hans2103 Now just a bit SCSS code style to be fixed. The linter finds following errors: |
|
@hans2103 I just see it's not only code style to be fixed. There is still a difference between LTR and RTL regarding the padding of the "x". See following comparison, LTR at the top, RTL below that: |
|
The linter is happy now, too. I have tested this PR ✅ with success. |
|
Thanks! |














Summary of Changes
This PR will convert the px values of choices css into relative sizes.
This PR will also increase font size selected tags.
This PR will also fix the position of the
xin the multi selectTesting Instructions
xat categories and notice the styling of present tags (add if none are present)npm run build:cssExpected result
Actual result
Documentation Changes Required