This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Add backgroud to html for the accessibility plugin#249
Merged
richard67 merged 1 commit intodevelopmentfrom Nov 22, 2020
Merged
Conversation
Contributor
|
Great idea. Could you make it slightly off white please. Pure white is a problem for people with dyslexia. Github uses #fafbfc |
Contributor
|
sorry ignore me |
hans2103
approved these changes
Nov 21, 2020
Member
|
I have tested this PR ✅ with success. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #66 .
Summary of Changes
Added a background color to html. This enables the accessibility plugin to invert the backend colour.
Testing Instructions
Apply the patch, (npm run build:css) then first make sure that all colours are as usual.
Then activate the accessibility plugin for the frontend and activate inverse colour
Expected result
All colours are inverted
Actual result
Colours are only inverted sidebars but hot for the whole site
Documentation Changes Required