[blog sample data] New attempt with different images.#248
[blog sample data] New attempt with different images.#248richard67 merged 5 commits intodevelopmentfrom
Conversation
|
@chmst You set the new "alt empty" flag to 1 in sample data for the articles' intro and full text images. Is that right? |
|
They are decorative so its ok but it would be nice to have an example in the sample data set that uses an alt description. This is a useful guide to when an image is decorative etc https://www.w3.org/WAI/tutorials/images/decision-tree/ |
|
Text data are always work for translators. But I have added two very short sample alt texts. |
bembelimen
left a comment
There was a problem hiding this comment.
If we're allowed to use the images license-wise, then it's good to go.
|
@drmenzelit @bembelimen Your approval was based on code review (which is fine and sufficient for an approval)? Or did you also do a real test? |
|
Only code review this time |
|
code review |
richard67
left a comment
There was a problem hiding this comment.
Last changes fix the issues I've found.
|
Funny that 3 previous reviewers haven't found it. |
|
I have tested this PR ✅ with success. |
|
Thanks! |
Pull Request for Issue #4 .
Summary of Changes
Add different images from the nasa imagery (including a backlink). Images are cut and size is optimised.
Testing Instructions
Install the blog sample data on a fresh joomla.
Expected result
kind of that:
Actual result
Only one image (the banner is used everywhere)
Documentation Changes Required
screens maybe