Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

Comments

Improvement on font-family and font-size for editor.css#246

Merged
hans2103 merged 1 commit intodevelopmentfrom
development-editor
Nov 21, 2020
Merged

Improvement on font-family and font-size for editor.css#246
hans2103 merged 1 commit intodevelopmentfrom
development-editor

Conversation

@drmenzelit
Copy link
Collaborator

Pull Request for Issue #233 .

Summary of Changes

Change font-family and font-size in templates/system/editor.css
font-family is like in Bootstrap a long list of system fonts
font-size is now in rem not in px

Testing Instructions

Edit an article in frontend or backend, you should see the difference in font size

Expected result

Font is bigger as before

@richard67
Copy link
Member

This will solve the issue only if font scheme "None" is selected in the template style options. If any other font scheme is applied, the fonts in frontend and in the editor in backend will again be different.

@drmenzelit
Copy link
Collaborator Author

Because the editor is in an iFrame, it can "read" what is outside coming from the template. Importing Bootstrap / template things will bloat the file unnecessarily. If the user wants to have all template definitions in the editor, he/she can load the template.css or another special editor.css file in the configuration on the TinyMCE plugin.

@richard67
Copy link
Member

@hans2103 Could you review this one here? Thanks in advance.

@chmst
Copy link
Collaborator

chmst commented Nov 19, 2020

I am not sure if it is a good idea to change the editor.css of the system.
woudn't it be better to add an editor.css to cassiopeia?

@brianteeman
Copy link
Contributor

@chmst If there were/are any specific cassiopeia changes then you are correct it should be in an editor.css for cassiopeia. However it looks like all of these are just modernisations and belong in the system editor.css

Ideally cassiopeia should ship with an editor.css to serve as an example (even if its not really needed perhaps). The editor.css has always been a bit of a hidden secret and we should give it more exposure.

@chmst
Copy link
Collaborator

chmst commented Nov 19, 2020

It was my intention that we have an editor.css as example in cassiopeia.
But this is then another PR.

@hans2103 hans2103 merged commit 57025ea into development Nov 21, 2020
@richard67 richard67 deleted the development-editor branch November 21, 2020 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants