This repository was archived by the owner on Jan 25, 2021. It is now read-only.
#242 revert removal of id="back-top" to prevent #top in the url after clicking back-top#244
Merged
chmst merged 1 commit intodevelopmentfrom Nov 17, 2020
Merged
Conversation
#242 revert removal of `id="back-top"` to prevent `#top` in the url after clicking back-top
drmenzelit
approved these changes
Nov 17, 2020
Collaborator
|
I have tested it successfully |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #242 .
Summary of Changes
this PR will revert the removal of
id="back-top"in the link which leads back to top.Adding the id will trigger javascript to preventDefault
Testing Instructions
Expected result
Actual result
Documentation Changes Required