This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Fluid font size for display classes#241
Merged
richard67 merged 1 commit intodevelopmentfrom Nov 15, 2020
Merged
Conversation
chmst
approved these changes
Nov 15, 2020
Collaborator
|
Very nice! I will change the headline in the banner module to display-2. |
Member
|
I have tested this PR ✅ with success. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Change the font size for display classes (.display-1 / .display-4 and .lead) using clamp() method
Testing Instructions
Run npm run build:css
Check the typography page (and also the banner on the home page) changing the size of the display
Expected result
The font size for the display classes changes fluidly
Actual result
The font size is the same despite the size of the display