This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Fix SCSS style linter reporting unexpected duplicate "position" for _back-to-top.scss#240
Merged
richard67 merged 1 commit intodevelopmentfrom Nov 15, 2020
Conversation
drmenzelit
approved these changes
Nov 15, 2020
richard67
deleted the
development-fix-scss-stylelint-duplicate-property
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for remaining issue mentioned in #235 .
Summary of Changes
Fixes the remaining SCSS code style errors found by the stylelint tool in the Cassiopeia template's SCSS files here:
https://github.com/joomla/cassiopeia/blob/development/templates/cassiopeia/scss/blocks/_back-to-top.scss#L22-L23
The duplicate property can't be avoided, as far as @drmenzelit told me.
So this PR adds a comment for the style linter to ignore that one line.
See https://stylelint.io/user-guide/ignore-code for how to do that.
Testing Instructions
Checkout the branch of this PR, then run
composer installandnpm ci, then runnode ./node_modules/stylelint/bin/stylelint.js --config build/.stylelintrc.json -s scss "templates/**/*.scss"in the Joomla root folder.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No errors reported by the style linter.
Documentation Changes Required
None.