Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

Change colour value for $cyan (info)#236

Merged
richard67 merged 1 commit intodevelopmentfrom
development-info-colour
Nov 14, 2020
Merged

Change colour value for $cyan (info)#236
richard67 merged 1 commit intodevelopmentfrom
development-info-colour

Conversation

@drmenzelit
Copy link
Collaborator

Pull Request for Issue # .

Summary of Changes

Change hsl values for colour variable $cyan to make it more harmonic with the template colours

Testing Instructions

Run npm run build:css

Expected result

image

The info button is more blue

Actual result

image

@richard67
Copy link
Member

It's more clear why this change is good when showing the buttons together with the header.

Before PR:

2020-11-14_01

The info buttons doesn't really fit to the template colours.

After PR:

2020-11-14_02

Looks much better.

@richard67
Copy link
Member

The variable name "cyan" might be misleading now, but to change this would mean a lot more changes to be done, because that's a Bootstrap 4 variable.

@richard67
Copy link
Member

I have tested this PR ✅ with success.

@richard67 richard67 merged commit 32db786 into development Nov 14, 2020
@richard67 richard67 deleted the development-info-colour branch November 14, 2020 11:06
@richard67
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants