This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Feature cassiopeia/remove obsolete margin#194
Merged
chmst merged 3 commits intojoomla:developmentfrom Oct 22, 2020
hans2103:feature-cassiopeia/remove-obsolete-margin
Merged
Feature cassiopeia/remove obsolete margin#194chmst merged 3 commits intojoomla:developmentfrom hans2103:feature-cassiopeia/remove-obsolete-margin
chmst merged 3 commits intojoomla:developmentfrom
hans2103:feature-cassiopeia/remove-obsolete-margin
Conversation
drmenzelit
approved these changes
Oct 22, 2020
Member
|
@drmenzelit @hans2103 As the description says, this PR has to wait until joomla/joomla-cms#31195 is merged in the CMS repo. But now as this PR here has been approved, it is not protected anymore from being merged. So if someone of us works on a touch screen and falls asleep due to too much work and then accidently hits the merge button with his or her forehead, the PR gets merged. I am not happy with that. To be safe, @hans2103 could change the PR back to draft. |
Collaborator
Author
|
converted to draft |
Collaborator
|
Sorry for being too fast ;-) |
Collaborator
Author
|
Since joomla/joomla-cms#31195 has been merged, this PR is no longer a draft. |
Collaborator
|
Merged now, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue joomla/joomla-cms#31195
Summary of Changes
After merge of joomla/joomla-cms#31195 this PR will fix obsolete spacing between elements.
It removes the margin-bottom from both .breadcrumb and empty alert box. And it removes the empty alert box from the DOM.
Testing Instructions
xnpm run build:cssand repeat the steps aboveExpected result
The expected result is a gap of 1rem. Breadcrumb and the output of the component have no obsolete margin between the elements.
Actual result
The actual result is a gap bigger than 1rem. This is due to a margin-bottom on the breadcrumbs and a margin-top added to the empty alert box, although it is empty. It is a succeeding element and therefor it gets a margin-top.
Documentation Changes Required