This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Correct underline for menu on header#163
Merged
richard67 merged 3 commits intodevelopmentfrom Oct 2, 2020
Merged
Conversation
Collaborator
|
I have added some white lines for code styling. |
1 similar comment
Collaborator
|
I have added some white lines for code styling. |
hans2103
approved these changes
Oct 2, 2020
Member
|
I have tested this PR ✅ with success. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #162 .
Summary of Changes
Changed rules for non-metismenu on menu position (header)
Testing Instructions
Run npm
Expected result
No double underline on menu items when hovered for non-metismenu on position menu (header)
Actual result
Double underline