Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

Change to navbar-expand-md#153

Merged
richard67 merged 6 commits intodevelopmentfrom
development-media-query
Oct 1, 2020
Merged

Change to navbar-expand-md#153
richard67 merged 6 commits intodevelopmentfrom
development-media-query

Conversation

@drmenzelit
Copy link
Collaborator

Pull Request for Issue #86 .

Summary of Changes

Changed navbar-expand-lg to navbar-expand-md to have the same media query for hamburger menu and for the switch from horizontal to vertical in the top menu

Testing Instructions

Install patch, no npm needed

Expected result

When hamburger menu appears the menu items have a vertical layout

Actual result

Hamburger menu -> menu still horizontal

Copy link
Collaborator

@hans2103 hans2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and reviewed... both look good

@richard67
Copy link
Member

There is something wrong.

The following screenshots show from top to botton ongoing reduction of width, using Firefox screen size simulator. The sizes are shown at the top in the control field.

2020-09-30_1

2020-09-30_2

2020-09-30_3

2020-09-30_4

As you can see, the search module is still right beside the (now with this PR vertical) menu => OK.

Reducing width more, the search module goes below the menu => OK.

Reducing width more, the search module goes back to right beside the menu => ???

Reducing width more, the search module goes back to below the menu => OK.

@chmst
Copy link
Collaborator

chmst commented Sep 30, 2020

There seems to be only one solution which works always:
Change the ordering - show first the search form, then the menu. What do you think?

@drmenzelit
Copy link
Collaborator Author

@richard67 can you please test the last commit?

@richard67
Copy link
Member

@drmenzelit Yes, it solves the issue.

@richard67
Copy link
Member

I have tested this PR ✅ with success.

@richard67 richard67 merged commit 86da390 into development Oct 1, 2020
@richard67 richard67 deleted the development-media-query branch October 1, 2020 13:53
@richard67
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants