Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

Remove *.* selector from _forms.scss#151

Merged
richard67 merged 4 commits intodevelopmentfrom
development-buttons
Oct 1, 2020
Merged

Remove *.* selector from _forms.scss#151
richard67 merged 4 commits intodevelopmentfrom
development-buttons

Conversation

@drmenzelit
Copy link
Collaborator

Pull Request for Issue #106 .

Testing Instructions

Run npm ci or compile scss

Check all forms present on the page after login on frontend.
Check a compact list of tags (create a menu item for this)

Expected result

The buttons on a compact list of tags are aligned
Other forms are not affected and the spacing between fieldsets and between elements inside a fieldset is still correct.
grafik

Actual result

The buttons on a compact list of tags are not aligned

@brianteeman
Copy link
Contributor

Can we please not use derogatory terms in the pull requests. They become part of the history of Joomla. Thanks

@drmenzelit drmenzelit changed the title Remove lobotomized owl from _forms.scss Remove *.* selector from _forms.scss Sep 29, 2020
@drmenzelit
Copy link
Collaborator Author

Sorry, I thought it is a common name for the . selector

@hans2103
Copy link
Collaborator

Sorry, I thought it is a common name for the . selector

me too
I've got this term from Heydon Pickering as mentioned in article Axiomatic CSS and Lobotomized Owls

@hans2103
Copy link
Collaborator

This is what I see. I think the dropdown is too wide.
Schermafbeelding 2020-09-30 om 19 33 54

@infograf768
Copy link
Member

Please test
joomla/joomla-cms#30813

Where I propose a refactoring of the filters for contact list, and, if accepted, to be also used for articles list and normalized for tags list. Basically add a Clear button and use text instead of icons.

@infograf768
Copy link
Member

@hans2103
I can't reproduce your issue.

@richard67
Copy link
Member

@hans2103 Maybe your development branch is outdated? How are you testing?

@chmst
Copy link
Collaborator

chmst commented Oct 1, 2020

The pr of @infograf768 looks very promising - it could resolve all the filtering issues. #154 too.

@richard67
Copy link
Member

I have tested this PR ✅ with success.

  • I could reproduce the issue.
  • I can confirm it is solved when this PR is applied and npm ci has run.
  • I can't confirm @hans2103 's finding with the too wide dropdown for the list limit.

@richard67 richard67 merged commit 3adfbbb into development Oct 1, 2020
@richard67
Copy link
Member

Thanks!

@richard67 richard67 deleted the development-buttons branch October 1, 2020 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants