Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

Comments

Updated the "Working on your site" article#149

Merged
richard67 merged 4 commits intojoomla:developmentfrom
ohrionmartin:development
Sep 30, 2020
Merged

Updated the "Working on your site" article#149
richard67 merged 4 commits intojoomla:developmentfrom
ohrionmartin:development

Conversation

@ohrionmartin
Copy link
Member

Pull Request for Issue #95 .

Summary of Changes

Corrected the path to follow when installing a template in the working on your site article

Testing Instructions

Apply sample data in a fresh installation of Cassiopeia

Expected result

The new j4 way to install extensions (templates)

Actual result

The "working on your site" article still displays the old way to do it.

Merge with upstream branch
Changed path to install templates
@chmst
Copy link
Collaborator

chmst commented Sep 29, 2020

thank you, @ohrionmartin!

@drmenzelit
Copy link
Collaborator

I have tested this PR successfully

@brianteeman
Copy link
Contributor

Thanks for writing this. Could you please review the language style guide as it is very useful and should be applied here as well. Especially the words to watch section. This ensures that we are consistent in our terminology.

https://developer.joomla.org/en-gb-user-interface-text-guidelines/

Oh and please remove the references to "weblinks"

@ohrionmartin
Copy link
Member Author

Thanks for writing this. Could you please review the language style guide as it is very useful and should be applied here as well. Especially the words to watch section. This ensures that we are consistent in our terminology.

https://developer.joomla.org/en-gb-user-interface-text-guidelines/

Oh and please remove the references to "weblinks"

Alright, I'll do that and thank you for the feedback!

@richard67 richard67 merged commit cd8dd45 into joomla:development Sep 30, 2020
@richard67
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants