Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

removal demo-styling#137

Merged
richard67 merged 1 commit intojoomla:developmentfrom
hans2103:feature-cassiopeia/#136--remove-demo-styling
Sep 25, 2020
Merged

removal demo-styling#137
richard67 merged 1 commit intojoomla:developmentfrom
hans2103:feature-cassiopeia/#136--remove-demo-styling

Conversation

@hans2103
Copy link
Copy Markdown
Collaborator

@hans2103 hans2103 commented Sep 25, 2020

Pull Request for Issue #136 .

Summary of Changes

removal obsolete demo-styling.scss

Testing Instructions

  • apply patch
  • npm ci
  • styling of site should not differ, since classNames in removed scss are not used.

Expected result

Actual result

Documentation Changes Required

@hans2103 hans2103 mentioned this pull request Sep 25, 2020
Closed
richard67
richard67 approved these changes Sep 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@richard67 richard67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that it's not used anywhere.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Sep 25, 2020

I have tested this PR ✅ with success. No visual changes.

@richard67 richard67 merged commit f4f2342 into joomla:development Sep 25, 2020
@richard67
Copy link
Copy Markdown
Member

richard67 commented Sep 25, 2020

Thanks

@hans2103 hans2103 deleted the feature-cassiopeia/#136--remove-demo-styling branch September 28, 2020 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@richard67 richard67 richard67 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hans2103 @richard67