This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Solve layout problems with search module on mobile#135
Merged
richard67 merged 1 commit intodevelopmentfrom Sep 25, 2020
Merged
Conversation
Collaborator
|
This is what I see.. is that what you had in mind?
|
Collaborator
Author
|
Exactly |
hans2103
approved these changes
Sep 25, 2020
Closed
Member
|
I have tested this PR ✅ with success. |
Member
|
@hans2103 Have you done a real test or just a code review? |
Collaborator
Code review and a real test. I've noticed a jump on the search when I opened the menu. I think it is ugly, but the issue as stated by Brian has been solved with this PR. This PR is an improvement of previous state. Screenshots have been taken from my computer. That should indicate a real test. Not only code review |
Member
|
Thanks. |
Contributor
|
Is this intended behaviour
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #133 and #118 .
Summary of Changes
Set a max-width for input on search
Set nowrap for input-group
Correct rounded borders when no search button present (only search input)
Move awesomplete code fron _global.scss to _awesomplete-.scss
Change height of banner module on small displays
Testing Instructions
Run npm ci
Expected result
The search button doesn't break on a new line on small displays
The input field has 4 rounded borders when search button not present (parameter in module)
Banner content isn't covert by the header