Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

Remove the white border on active pagination elements#131

Merged
richard67 merged 5 commits intojoomla:developmentfrom
hans2103:feature-cassiopeia/#107--pagination-remove-borders
Sep 25, 2020
Merged

Remove the white border on active pagination elements#131
richard67 merged 5 commits intojoomla:developmentfrom
hans2103:feature-cassiopeia/#107--pagination-remove-borders

Conversation

@hans2103
Copy link
Copy Markdown
Collaborator

Pull Request for Issue #107.

Summary of Changes

This PR removes the white border on active pagination elements.
Removing grey border on disabled elements has consequences for disabled page-links as well.

Testing Instructions

  • Joomla 4 with Testing Sample Data
  • Go To /index.php/article-category-list
  • Apply patch
  • npm run build:css
  • Notice borders around all pagination items

Expected result

Schermafbeelding 2020-09-24 om 22 20 31

Actual result

Documentation Changes Required

@drmenzelit
Copy link
Copy Markdown
Collaborator

It is intended to have rounded corners left and right on first and last element?

@hans2103
Copy link
Copy Markdown
Collaborator Author

It is intended to have rounded corners left and right on first and last element?

I don't know... not the designer. :-)
But...commit 0f47991 fixes the border radius on first and last child

@hans2103
Copy link
Copy Markdown
Collaborator Author

d0fccf6 removes radius, since it is already set

@hans2103 hans2103 mentioned this pull request Sep 25, 2020
@richard67
Copy link
Copy Markdown
Member

I have tested this PR ✅ with success.

@chmst
Copy link
Copy Markdown
Collaborator

chmst commented Sep 25, 2020

Tested with success for the border .

@richard67 richard67 merged commit 9cecc74 into joomla:development Sep 25, 2020
@richard67
Copy link
Copy Markdown
Member

Thanks.

@hans2103 hans2103 deleted the feature-cassiopeia/#107--pagination-remove-borders branch September 28, 2020 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants