This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Merged
Conversation
### Steps to reproduce the issue Clean install of development branch ### Expected result no console errors ### Actual result 404 error on `templates/media/vendor/roboto-fontface/scss/roboto/roboto-fontface.css` ### Comment The path should be `media/vendor/roboto-fontface/scss/roboto/roboto-fontface.css` ### This PR This PR corrects the path in fonts-local_roboto.scss
hans2103
approved these changes
Sep 24, 2020
Member
|
I have tested this PR ✅ with success. |
Member
|
Thanks! |
Contributor
Author
|
No problem - it was an obvious error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue
Clean install of development branch
Expected result
no console errors
Actual result
404 error on
templates/media/vendor/roboto-fontface/scss/roboto/roboto-fontface.cssComment
The path should be
media/vendor/roboto-fontface/scss/roboto/roboto-fontface.cssThis PR
This PR corrects the path in fonts-local_roboto.scss