Skip to content

migrations/53-54 Removed 45685#510

Merged
richard67 merged 1 commit intojoomla:mainfrom
muhme:migrations-53-54-remove-45685
Aug 31, 2025
Merged

migrations/53-54 Removed 45685#510
richard67 merged 1 commit intojoomla:mainfrom
muhme:migrations-53-54-remove-45685

Conversation

@muhme
Copy link
Contributor

@muhme muhme commented Aug 31, 2025

User description

As #45685 - 'Notify all super users of Automated Updates' functionality is overwritten by #45721 - 'Autoupdate email groups'.


PR Type

Documentation


Description

  • Remove duplicate automated update notification feature from migration docs

  • Clean up feature list after functionality consolidation


Diagram Walkthrough

flowchart LR
  A["Migration docs 53-54"] -- "remove duplicate" --> B["Cleaned feature list"]
  C["PR 45685 functionality"] -- "replaced by" --> D["PR 45721 email groups"]
Loading

File Walkthrough

Relevant files
Documentation
new-features.md
Remove duplicate automated update notification entry         

migrations/53-54/new-features.md

  • Removed reference to PR 45685 from automated updates feature list
  • Cleaned up duplicate functionality documentation
+0/-1     

As 45685 - 'Notify all super users of Automated Updates' functionality
is overwritten by 45721 - 'Autoupdate email groups'.
@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Cross-reference Consistency

Verify that all other mentions of PR 45685 are removed or properly referenced elsewhere in the docs to avoid confusion, and that PR 45721 fully supersedes it in any linked sections or release notes.

* [45143](https://github.com/joomla/joomla-cms/pull/45143) Add Automated Core Updates client functionality
* [45517](https://github.com/joomla/joomla-cms/pull/45517) Add Automated Updates information as fieldset description
* [45547](https://github.com/joomla/joomla-cms/pull/45547) Improve Automated Update UX for local sites
* [45669](https://github.com/joomla/joomla-cms/pull/45669) Improve Automated Update Quickicon language keys and icon
* [45697](https://github.com/joomla/joomla-cms/pull/45697) Allow opt-out from automated updates during installation
* [45721](https://github.com/joomla/joomla-cms/pull/45721) Autoupdate email groups

@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@muhme
Copy link
Contributor Author

muhme commented Aug 31, 2025

@richard67 It is now the same as in the news article for developers. Could you please check and merge?

@HLeithner HLeithner added the Waiting for Joomla reference PR This pr is ready to merge and can be merged when the corresponding Joomla cms pr is merged. label Aug 31, 2025
@richard67
Copy link
Member

@HLeithner The label "Waiting for Joomla reference PR" does not make much sense here as this PR removes a CMS PR from the list as it was superseded by a later one.

@richard67 richard67 merged commit ef394e4 into joomla:main Aug 31, 2025
2 checks passed
@richard67
Copy link
Member

Thanks.

@richard67 richard67 removed the Waiting for Joomla reference PR This pr is ready to merge and can be merged when the corresponding Joomla cms pr is merged. label Aug 31, 2025
@muhme muhme deleted the migrations-53-54-remove-45685 branch August 31, 2025 07:41
@HLeithner
Copy link
Member

I might have not understand you description. #45721 has not been merged yet?

@muhme
Copy link
Contributor Author

muhme commented Aug 31, 2025

#45721 is merged and overwrites the implementation of #45685, therefore #45685 is deleted from the new features list

@richard67
Copy link
Member

I might have not understand you description. #45721 has not been merged yet?

@HLeithner It has been merged: joomla/joomla-cms#45721 . When you search for it on GitHub, you find another PR which is still open and draft and refers to that one in its description. Maybe that confused you?

@HLeithner
Copy link
Member

A sorry I looked up the wrong pr, since you just posted the number my search for the number lead me to the wrong pr in the cms. all good sry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants