Map keys control+s to save command on forms

[dgrammatiko]

Pull Request for Issue # .

Summary of Changes

• Added one more layout for toolbar apply button
• Added needed code in core.js to support mapping key press to save

Testing Instructions

Documentation Changes Required

[C-Lodder]

Could u please test on windows @DGT41.

Just tested and it's not working

[zero-24]

3.0 ? Should this not be __DEPLOY_VERSION__ or 4.0?

[dgrammatiko]

yup

[wilsonge]

Doesn't work for me on macbook either

[dgrammatiko]

For mac is command+s

By the way which view did you try? (article edit)

[C-Lodder]

yes i did that (george here) - it tried to save html contents of the page. i did also read your js :P

[dgrammatiko]

can you insert a console.log(Joomla.getOptions( 'keySave' ).task); before this line?
what it is in the console?

[C-Lodder]

article.apply

[dgrammatiko]

Joomla.submitbutton(button);

@C-Lodder try with the above code

[C-Lodder]

Ok I know the issue now.

You can't be focused on the editor when using CTRL + S. You need to click outside the editor for it to work.

This only happens with TinyMCE.

[dgrammatiko]

add a console.log(''pressed: ' + e.keyCode + ' and ' + e.ctrlKey );
What happens when you press keys?

[dgrammatiko]

or try

if (String.fromCharCode(e.which).toLowerCase() == 's' && (navigator.platform.match("Mac") ? e.metaKey : e.ctrlKey)) {

[dgrammatiko]

British keyboards, I guess your s is mapped to some other keyCode 😄

[C-Lodder]

Tiny mce loads in an iframe so i guess the iframe doesn't load the keybindings (george)

[dgrammatiko]

Ahh, crap, I didn;t try it with focus in tiny window (?)

[C-Lodder]

xD

[dgrammatiko]

solution here: http://stackoverflow.com/questions/5732370/make-tinymcejeditable-submit-after-pressing-ctrls

[C-Lodder]

behaviour core is being loaded in the if and the else can we just load it outside the if and then remove the else?

[wilsonge]

Go for it then :)

[C-Lodder]

@DGT41 - Forget the research, already solved it:

tinymce-init.js (line 62 directly above tinyMCE.init(options);), add the following:

options.plugins = 'save';
options.toolbar = 'save';
options.save_onsavecallback = function() { Joomla.submitbutton('article.apply'); }

This is the only bit of code you need, so you can revert all the other changes you've made.

[dgrammatiko]

The only problem is that article.apply will work only in articles, so it needs something more...

[dgrammatiko]

last commit:

• remove tiny close script (mootools modal thingy)
• make tinyMCE init script vanilla
• add support for ctrl+s

NOTE: if you haven't change anything in the editor area (no new text, etc) the save will not initiate!

With this ctrl+s works on all editors that comes with Joomla

[C-Lodder]

All working now :)