Update SQL Scripts for Postgresql and MySQL and Code Cleanup #6

khu5h1 · 2022-07-22T17:52:56Z

Summary of Changes

bembelimen

When cleaned up, we can merge asap

administrator/components/com_admin/sql/updates/mysql/4.2.0-2022-06-16.sql

…ql and MySQL

administrator/components/com_admin/sql/updates/postgresql/4.3.0-2022-07-30.sql

plugins/system/tour/tour.php

administrator/language/en-GB/com_guidedtours.ini

…s/gsoc22_guided-tour into cleanup

…d-tour into cleanup

…e title in the steps view.

administrator/components/com_admin/sql/updates/postgresql/4.3.0-2022-07-30.sql

- Some code style fixes - Be consistent with how you specify primary keys in MySQL - On update, insert new extensions with one insert statement and use ordering 0

Add missing extensions record for the plugin for new installations on PostgreSQL

- The checked_out and checked_out_time columns meanwhile allow null values and so also should not have a default value. - Use data types consistent with other tables for these columns.

- Use correct data types in PostgreSQL. - Remove "state" column which is not used for MySQL either.

See joomla/joomla-cms#37156 for details.

The soundex function has to be the last thing in this file.

- Do not use wrong values for created and modified times. - Do not use hardcoded user ID.

- Hardcoded MySQL names quotes in this query lead to an SQL error on PostgreSQL databases - Added other missing names quotes

Remove wrong code possibly resulting from copy and paset

The database checker for PostgreSQL seems to have a problem when the opening bracket is in a new line. This has to be fixed elsewhere, For now adapt to this behavior.

richard67 · 2022-08-16T18:55:11Z

For fixes on SQL, especially for PostgreSQL, see #10 .

…uided-tour into cleanup-fix-sql-2022-08-13

SQL fixes for PR #6

khu5h1 added 3 commits July 22, 2022 23:15

Update SQL Scripts for Postgresql and MySQL

f40a7b1

Deleted one update sql script for Postgresql

a6a3fd7

Removed Label from Hidden Field

471a493

khu5h1 changed the title ~~Update SQL Scripts for Postgresql and MySQL~~ Update SQL Scripts for Postgresql and MySQL and Code Cleanup Jul 22, 2022

Code cleanup

e8cbf13

bembelimen suggested changes Jul 30, 2022

View reviewed changes

administrator/components/com_admin/sql/updates/mysql/4.2.0-2022-06-16.sql Show resolved Hide resolved

administrator/components/com_admin/sql/updates/mysql/4.2.0-2022-06-16.sql Outdated Show resolved Hide resolved

khu5h1 added 5 commits July 30, 2022 15:25

Update String Value for Relative URL

6128b26

Added extra lines in the end

b3e25bd

Increase the file version to 4.3 for Update SQL Scripts for Postgres…

8704ab4

…ql and MySQL

Deleted 4.2 update sql script for Postgresql and Mysql

697e7ad

Code Cleanup

f149b4b

brianteeman reviewed Jul 31, 2022

View reviewed changes

administrator/components/com_admin/sql/updates/postgresql/4.3.0-2022-07-30.sql Outdated Show resolved Hide resolved

brianteeman reviewed Jul 31, 2022

View reviewed changes

plugins/system/tour/tour.php Outdated Show resolved Hide resolved

brianteeman reviewed Jul 31, 2022

View reviewed changes

plugins/system/tour/tour.php Outdated Show resolved Hide resolved

brianteeman reviewed Jul 31, 2022

View reviewed changes

administrator/language/en-GB/com_guidedtours.ini Outdated Show resolved Hide resolved

khu5h1 and others added 4 commits August 2, 2022 18:24

Merge branch 'infra-guided-tour' of https://github.com/joomla-project…

b639b31

…s/gsoc22_guided-tour into cleanup

Code Cleanup

ec84033

Update drone signature for tests

ea8b5a3

Merge branch 'dev' of https://github.com/joomla-projects/gsoc22_guide…

638bda3

…d-tour into cleanup

khu5h1 requested a review from rdeutz as a code owner August 2, 2022 14:53

khu5h1 added 5 commits August 2, 2022 20:30

Cleanup

51a02ad

Resolved Warnings and followed coding standards for tests

61ba835

Resolved Warning for Test

2797a97

Added comment for PHPCS error

fc92d7e

Used Standard Headings for the Views and removed the tours id from th…

f445336

…e title in the steps view.

brianteeman reviewed Aug 3, 2022

View reviewed changes

administrator/components/com_admin/sql/updates/postgresql/4.3.0-2022-07-30.sql Outdated Show resolved Hide resolved

khu5h1 mentioned this pull request Aug 4, 2022

Base Structure for Guided tour #1

Open

khu5h1 added 3 commits August 4, 2022 19:58

String value changes for tour and steps

1908dbd

Code cleanup

ab4008a

Used shorthand

ff06055

richard67 added 11 commits August 13, 2022 15:24

Consistency and code style fixes

586d90f

- Some code style fixes - Be consistent with how you specify primary keys in MySQL - On update, insert new extensions with one insert statement and use ordering 0

Add missing extension record

1f86bed

Add missing extensions record for the plugin for new installations on PostgreSQL

Fix checked out columns to allow null values

1632e40

- The checked_out and checked_out_time columns meanwhile allow null values and so also should not have a default value. - Use data types consistent with other tables for these columns.

Correct data types in PostgreSQL

fee4177

- Use correct data types in PostgreSQL. - Remove "state" column which is not used for MySQL either.

Add CAN FAIL installer hint for PostgreSQL

2171c9b

See joomla/joomla-cms#37156 for details.

Fix for PostgreSQL

d785720

Fix extensions.sql for PostgreSQL

1e41ab9

The soundex function has to be the last thing in this file.

Use correct values for created, modified and checked out columns

2d7652e

- Do not use wrong values for created and modified times. - Do not use hardcoded user ID.

Fix my error from previous commit

a75a5f0

Another invalid data type for PostgreSQL

ff39443

Fix names quoting

b06deb9

- Hardcoded MySQL names quotes in this query lead to an SQL error on PostgreSQL databases - Added other missing names quotes

richard67 mentioned this pull request Aug 13, 2022

SQL fixes for PR #6 #10

Merged

richard67 added 11 commits August 13, 2022 17:52

Use double quotes inside SQL strings

d376f86

Fix checked out column for PostgreSQL, too

e1d131f

Fix checked out columns in MySQL update SQL script

ebedea3

Add null value support to table classes

2c2c794

Remoce copy and paste remainders

34a6f5b

Remove wrong code possibly resulting from copy and paset

SQL code style: Reserved words uppercase

fd748cf

Add PHPCS exception for underscore

a39b1a9

Checked out for steps table

a4194d9

Add new core extensions to extensions helper

9c2b001

Fix for the database checker

9cfdfc0

The database checker for PostgreSQL seems to have a problem when the opening bracket is in a new line. This has to be fixed elsewhere, For now adapt to this behavior.

Adapt code style for some tables to the others

35f806b

Added link of tour on steps view URL

8e96dab

khu5h1 force-pushed the cleanup branch from bb3309e to 8e96dab Compare August 18, 2022 20:22

khu5h1 and others added 3 commits September 4, 2022 17:03

Merge branch 'cleanup' of https://github.com/joomla-projects/gsoc22_g…

d381c4e

…uided-tour into cleanup-fix-sql-2022-08-13

Sync up changes with clean up branch

2cc268b

Merge pull request #10 from richard67/cleanup-fix-sql-2022-08-13

2e6c962

SQL fixes for PR #6

khu5h1 merged commit 032fd47 into infra-guided-tour Sep 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update SQL Scripts for Postgresql and MySQL and Code Cleanup #6

Update SQL Scripts for Postgresql and MySQL and Code Cleanup #6

Uh oh!

khu5h1 commented Jul 22, 2022 •

edited

Loading

Uh oh!

bembelimen left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

richard67 commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Update SQL Scripts for Postgresql and MySQL and Code Cleanup #6

Update SQL Scripts for Postgresql and MySQL and Code Cleanup #6

Uh oh!

Conversation

khu5h1 commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Uh oh!

bembelimen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

richard67 commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

khu5h1 commented Jul 22, 2022 •

edited

Loading