This repository was archived by the owner on Sep 9, 2020. It is now read-only.
WIP - Editor everywhere #75
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for integrating the page builder into the rest of the system.
TODO:
Summary of Changes
The index.php from Apodis should not be the only place for using the page builder. With this PR the page builder can be set as (default) editor. So articles, custom HTML modules, and even template overrides are able to use it. The rendering happens directly on every change by using Ajax. Elements can be set for content, layout or both.
Testing Instructions
Create a new article, custom module and template override.
Play with the editor and the elements.
Try out to change the context of an element, by changing its configuration.
Save and visit your creation on the frontend.
Expected result
The editor should be integrated successfully. Only the desired elements are selectable. The correct build-up of elements should appear on the frontend.
Actual result
The editor is available in the Template Style tab of Apodis only.
Documentation Changes Required
Yes.