This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Improved Sidebar, colorpicker added #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved in the json file for the database
…hen opening the settings sidebar
…ened at the same time
…and displayed in sidebar after refresh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Styling changes in sidebar to improve usability.
Added color picker to sidebar to provide the option to chose Background Color, Font Color and Link Color. Link color isn't fully implemented yet. The option is only avaliable when opening the settings sidebar for a column.
To render the frontend we extended the com_template plugins which handle the rendering of the pagebuilder settings to render now also inline css.
Testing Instructions
Open the Pagebuilder in the apodis - Default template
Add a grid with any amount of columns
Add content to at least on of the columns (alternatively you can also increase the height of the column on the site manually to see the changes to the background color)
Open the settings sidebar of a column
Chose any color in the colorpicker for example for the background color
Save the template and set it as your default template
Open the frontend
Expected result
The color changes to the specific columns are displayed.
Actual result
Colorpicker doesn't exist in the sidebar.
Documentation Changes Required
Not that I know.