Improvements when saving translation file#290
Merged
infograf768 merged 2 commits intojoomla-projects:developfrom Mar 21, 2016
Merged
Improvements when saving translation file#290infograf768 merged 2 commits intojoomla-projects:developfrom
infograf768 merged 2 commits intojoomla-projects:developfrom
Conversation
Contributor
Author
|
To test, install the patched version of com_localise with 2 languages and edit one ini file from the Translations view (test with a non en-GB file). |
| COM_LOCALISE_LABEL_TRANSLATION_SOURCE_DESC="Press Ctrl-Q to toggle Full Screen editing." | ||
| COM_LOCALISE_LABEL_TRANSLATION_VERSION="Version" | ||
| COM_LOCALISE_LABEL_TRANSLATION_VERSION_DESC="" | ||
| COM_LOCALISE_NOTICE_TRANSLATION_COMPLETE="The transation file has been saved as 'Complete'." |
Contributor
There was a problem hiding this comment.
translation
note the missing l
Contributor
|
Good idea. |
infograf768
added a commit
that referenced
this pull request
Mar 21, 2016
Improvements when saving translation file
Contributor
|
@infograf768 IMHO i think we need to revise this repository structure so we can use the patchtester to test this repository PR. It will be a lot simpler to test PR. I think what is need is to change the administrator folder, from "component/admin" to "administrator/components/com_localise" and update the files that reference that folder. See the structure of the patchtester repository for more info https://github.com/joomla-extensions/patchtester |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
1_ A confirm dialog when saving and save and close an edited ini file to remind user to set as desired the "Complete" field.
2_ A Notice, after saving the file, stating if the "Complete" status has been set or not.
3_ It changes the Complete field from a checkbox to a radio type yes/No