Throw a warning when max_input_vars value is too low.#287
Merged
infograf768 merged 2 commits intojoomla-projects:developfrom Mar 18, 2016
Merged
Throw a warning when max_input_vars value is too low.#287infograf768 merged 2 commits intojoomla-projects:developfrom
infograf768 merged 2 commits intojoomla-projects:developfrom
Conversation
Contributor
|
Well done. Regards. |
infograf768
added a commit
that referenced
this pull request
Mar 18, 2016
Throw a warning when max_input_vars value is too low.
Contributor
Author
|
Thanks for testing |
This was referenced Mar 18, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, based partly on code from @Valc in #276
implements a Warning when the php.ini directive
max_input_varsis lower than required to edit an ini file. It also prevents editing the file except under Source.One should get:
The default on most systems is 1000 if the directive is not set at all.
To test, add 50 lines to admin en-GB.ini.
Modify the directive and test again.
The reason we can't use
$item->totalis that lines with comments are also counted as variables.