Skip to content

Strings protection againt max_input_vars limit #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Valc wants to merge 11 commits into from
Closed

Strings protection againt max_input_vars limit #276

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
da3abae
Merge pull request #5 from Valc/valc-keys
Jan 29, 2015
253d9a6
Return to main dev
Valc Feb 6, 2015
21cc688
chmod
Valc Feb 6, 2015
33609aa
Merge branch 'develop' of git://github.com/joomla-projects/com_locali…
Valc Feb 8, 2015
58c5f07
Merge branch 'joomla-projects-develop' into develop
Valc Feb 8, 2015
1d46217
Merge pull request #13 from joomla-projects/develop
Feb 9, 2015
2f49556
Merge pull request #15 from joomla-projects/develop
Feb 10, 2015
ee4950b
Merge pull request #17 from joomla-projects/develop
Feb 10, 2015
668c14f
Merge pull request #20 from joomla-projects/develop
Feb 25, 2015
4d5b262
Merge pull request #22 from joomla-projects/develop
Apr 21, 2015
8965031
Strings protection against max_input_vars limit.
Valc Apr 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions component/admin/views/translations/tmpl/default_body.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,17 @@
$user = JFactory::getUser();
$userId = $user->get('id');
$lang = JFactory::getLanguage();
$max_vars = ini_get('max_input_vars');
?>
<?php foreach ($this->items as $i => $item) : ?>
<?php
$limit = 0;

if ($max_vars > 0 && $item->total > $max_vars)
{
$limit = 1;
}
?>
<?php $canEdit = $user->authorise('localise.edit', 'com_localise' . (isset($item->id) ? ('.' . $item->id) : '')); ?>
<tr class="<?php echo $item->state; ?> row<?php echo $i % 2; ?>">
<td width="20" class="center hidden-phone"><?php echo $i + 1; ?></td>
Expand Down Expand Up @@ -63,9 +72,14 @@
<input type="checkbox" id="cb<?php echo $i; ?>" class="hidden" name="cid[]" value="<?php echo $item->id; ?>">
<?php endif; ?>
<?php if ($item->writable && !$item->error && $canEdit) : ?>
<a class="hasTooltip" href="<?php echo JRoute::_('index.php?option=com_localise&task=translation.edit&client='.$item->client.'&tag='.$item->tag.'&filename='.$item->filename.'&storage='.$item->storage.'&id='.LocaliseHelper::getFileId(LocaliseHelper::getTranslationPath($item->client,$item->tag, $item->filename, $item->storage)).($item->filename=='override' ? '&layout=raw' :'')); ?>" title="<?php echo JText::_('COM_LOCALISE_TOOLTIP_TRANSLATIONS_' . ($item->state=='unexisting' ? 'NEW' : 'EDIT')); ?>">
<?php echo $item->name; ?>.ini
</a>
<?php if ($limit == 0) : ?>
<a class="hasTooltip" href="<?php echo JRoute::_('index.php?option=com_localise&task=translation.edit&client='.$item->client.'&tag='.$item->tag.'&filename='.$item->filename.'&storage='.$item->storage.'&id='.LocaliseHelper::getFileId(LocaliseHelper::getTranslationPath($item->client,$item->tag, $item->filename, $item->storage))); ?>" title="<?php echo JText::_('COM_LOCALISE_TOOLTIP_TRANSLATIONS_' . ($item->state=='unexisting' ? 'NEW' : 'EDIT')); ?>">
<?php echo $item->name; ?>.ini
</a>
<?php else : ?>
<?php echo "<font color=\"red\">" . $item->name . ".ini (Strings protection.)</font>"; ?>
<?php $app->enqueueMessage("The PHP directve 'max_input_vars' value is minor than the required one to edit the file: " . $item->tag . "." . $item->name . ".ini", 'warning'); ?>
<?php endif; ?>
<?php elseif (!$canEdit) : ?>
<?php echo JHtml::_('jgrid.action', $i, '', array('tip'=>true, 'inactive_title'=>JText::sprintf('COM_LOCALISE_TOOLTIP_TRANSLATIONS_NOTEDITABLE', substr($item->path, strlen(JPATH_ROOT))), 'inactive_class'=>'16-error', 'enabled' => false, 'translate'=>false)); ?>
<?php echo $item->name; ?>.ini
Expand Down