Merged
Conversation
Contributor
|
Can you update as I merged 2 PRs? |
Contributor
|
In fact just take out the changes to models/translations.php This works real good here |
This reverts commit eb98f48. require revert
Contributor
Author
|
Done :D |
Update from source
Contributor
|
@Valc and No use to create new strings for the filters. |
Contributor
|
Did a bit of cleaning. Also I see no reason for sprintf in the filter Options, example: |
Contributor
|
should be OK now. :) |
Contributor
Author
|
Yep, i had not noticed about that: well done. |
Valc
pushed a commit
to Valc/com_localise
that referenced
this pull request
Feb 10, 2015
Merge pull request joomla-projects#268 from Valc/keys-filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a JM idea, with this pull now we can to add in the "Localisation Manager: Edit translation" => "Strings" tab page a filter to filter by keys status (unchanged, translated, untranslated, etc.).
Seems is working and maybe can to be added in main brach with improved code.
Here there is a sample with untranslated strings:

Regards.