Skip to content

Keys filters#268

Merged
infograf768 merged 120 commits intojoomla-projects:developfrom
Valc:keys-filters
Feb 10, 2015
Merged

Keys filters#268
infograf768 merged 120 commits intojoomla-projects:developfrom
Valc:keys-filters

Conversation

@Valc
Copy link
Contributor

@Valc Valc commented Feb 8, 2015

Following a JM idea, with this pull now we can to add in the "Localisation Manager: Edit translation" => "Strings" tab page a filter to filter by keys status (unchanged, translated, untranslated, etc.).

Seems is working and maybe can to be added in main brach with improved code.

Here there is a sample with untranslated strings:
untranslated_filter

Regards.

@infograf768
Copy link
Contributor

Can you update as I merged 2 PRs?

@infograf768
Copy link
Contributor

In fact just take out the changes to models/translations.php

This works real good here

Valc added 2 commits February 8, 2015 17:58
@Valc
Copy link
Contributor Author

Valc commented Feb 8, 2015

Done :D

@infograf768
Copy link
Contributor

@Valc
we already have these strings:
COM_LOCALISE_TEXT_TRANSLATION_TRANSLATED="Translated"
COM_LOCALISE_TEXT_TRANSLATION_UNCHANGED="Unchanged"
COM_LOCALISE_TEXT_TRANSLATION_UNTRANSLATED="Untranslated"

and
JALL="All"
JOPTION_SELECT_PUBLISHED="- Select Status -"

No use to create new strings for the filters.

@infograf768
Copy link
Contributor

Did a bit of cleaning.

Also I see no reason for sprintf in the filter Options, example:
JText::sprintf('COM_LOCALISE_FILTER_ALL_KEYS')

@infograf768
Copy link
Contributor

should be OK now. :)

@Valc
Copy link
Contributor Author

Valc commented Feb 9, 2015

Yep, i had not noticed about that: well done.
Here is working great: happy to catch untranslated strings within large files in record times :D.

infograf768 added a commit that referenced this pull request Feb 10, 2015
@infograf768 infograf768 merged commit 56574e8 into joomla-projects:develop Feb 10, 2015
Valc pushed a commit to Valc/com_localise that referenced this pull request Feb 10, 2015
Merge pull request joomla-projects#268 from Valc/keys-filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants