Skip to content

Add an windows test with slash#39

Closed
zero-24 wants to merge 2 commits intojoomla-framework:masterfrom
zero-24:patch-1
Closed

Add an windows test with slash#39
zero-24 wants to merge 2 commits intojoomla-framework:masterfrom
zero-24:patch-1

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Jan 29, 2021

Pull Request for Issue joomla/joomla-cms#32076 cc @richard67 @nibra

Summary of Changes

Add an windows test with slash

Todo

  • extende the regex to allow the slash at the right place
    or
  • require the path to be passed via path::clean

Testing Instructions

Try to test the PR #32076 the test fails as there is a slash in the regex

Documentation Changes Required

none.

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@richard67
Copy link
Contributor

I've merged this one here into #40 , so this here could be closed.

@zero-24 zero-24 closed this Jan 29, 2021
@zero-24 zero-24 deleted the patch-1 branch January 29, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants