[3.x] Port improvements for opcache invalidation from CMS - redo PR #38 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalidate the OPCache for the file before actually deleting it. See https://www.php.net/manual/en/function.opcache-invalidate.php#116372
Invalidate opcache of uploaded temp file before saving to target file
Check if - opcache is enabled, and - the opcache_invalidate function is available, and - calling opcache_invalidate is not restricted by opcache.restrict_api or it is restricted to allow the currently executing script and save the result in a static variable.
|
I have successfully tested that this fixes the issue joomla/joomla-cms#45681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
This pull request is a redo of PR #38 , which was closed by its author for unrelated reasons.
In opposite to that PR, it does not introduce a new method to check if opcache can be invalidated but checks that locally in the
invalidateFileCachemethod, and it does not extend theinvalidateFileCachemethod by a new parameter if the invalidation shall be forced.Besides these differences in implementation, the changes here are functionally the same as in the closed PR.
The changes were once implemented in the file system classes of the CMS with PR joomla/joomla-cms#32915 , which was intensively tested by me at that time.
In detail the changes are following, done with separate commits in this PR so they can be easily verified:
See https://www.php.net/manual/en/function.opcache-invalidate.php#116372 .
This is done in the
movemethod and for the temporary upload file also in theuploadmethod.Testing Instructions
Will be added soon.
Documentation Changes Required
None.