Skip to content

Comments

set_time_limit php 8#59

Closed
brianteeman wants to merge 7 commits intojoomla-framework:2.0-devfrom
brianteeman:patch-1
Closed

set_time_limit php 8#59
brianteeman wants to merge 7 commits intojoomla-framework:2.0-devfrom
brianteeman:patch-1

Conversation

@brianteeman
Copy link
Contributor

Also see joomla/joomla-cms#41523

Summary of Changes

some hosts disable set_time_limit in php

Prior to PHP 8.0.0, it was possible for the @ operator to disable critical errors that will terminate script execution. For example, prepending @ to a call of a function which did not exist, by being unavailable or mistyped, would cause the script to terminate with no indication as to why.

This PR replaces the @ with a function_exists check

Testing Instructions

code review or in php.ini
disable_functions = set_time_limit

Actual result BEFORE applying this Pull Request

Admin dashboard loads with an error
finder index ends with an error

Expected result AFTER applying this Pull Request

everything works

@brianteeman brianteeman closed this Sep 8, 2023
@brianteeman brianteeman deleted the patch-1 branch September 8, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant