Error Resistible Event interface#34
Closed
Fedik wants to merge 7 commits intojoomla-framework:3.x-devfrom
Closed
Conversation
Author
|
I have changed original implementation to be sure all errors is handled, and nothing gets "muted" by accident. |
Author
|
Another way of doing it, would be on Dispatcher level (instead of fancy interface for events). Thoughts? |
Author
|
This will be better #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
A new interface, ErrorResistibleEventinterface, for error resistible events.
The event that implement this interface do not crash the dispatching process when an exception happening.
The dispatcher collect errors during this event, and gives it to the event for further handling.
This can help to solve issue for crashed system plugins in CMS. (In combination with joomla/joomla-cms#40522 and some update for exceptions handler.)
Testing Instructions
Test passes
Documentation Changes Required
A new feature.