PostgreSQL - return the same string each time of call __toString() on update query with join #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @csthomas |
mbabker
suggested changes
Jan 15, 2017
| /** | ||
| * The instance of the object to test. | ||
| * | ||
| * @var PostgresqlQuery |
| * | ||
| * @var PostgresqlQuery | ||
| * @since _VERSION_NAME_ | ||
| */ |
There was a problem hiding this comment.
Unless there is an actual need, let's not introduce an underscore prefixed variable.
There was a problem hiding this comment.
I'll remove the underscore but leave the variable, I just followed what the CMS did for the test changes with test__toStringUpdate()
| * @param boolean $new True to get a new query, false to get the last query. | ||
| * | ||
| * @return PostgresqlQuery | ||
| * |
There was a problem hiding this comment.
fixed all of these to the correct string
src/Postgresql/PostgresqlQuery.php
Outdated
| $query .= (string) $this->where; | ||
| } | ||
|
|
||
| $this->from = $tmpFrom; |
There was a problem hiding this comment.
Extra indenting here and the next line.
Tests/QueryPostgresqlTest.php
Outdated
| * @return void | ||
| * | ||
| * @see PHPUnit_Framework_TestCase::tearDown() | ||
| * @since _VERSION_NAME_ |
mbabker
approved these changes
Jan 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue - backports joomla/joomla-cms#13284
Summary of Changes
Testing Instructions
Test by travis.
Code review.
Documentation Changes Required
none