Allow IPv6 addresses with brackets for pgsql#315
Closed
muhme wants to merge 1 commit intojoomla-framework:3.x-devfrom
Closed
Allow IPv6 addresses with brackets for pgsql#315muhme wants to merge 1 commit intojoomla-framework:3.x-devfrom
muhme wants to merge 1 commit intojoomla-framework:3.x-devfrom
Conversation
This unifies with MySQL and MariaDB and allows to set port number.
This was referenced Oct 8, 2024
richard67
reviewed
Oct 28, 2024
Author
|
This PR has been replaced by the alternative #316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 DRAFT as to be extended by unit tests and documentation
Summary of Changes
IPv6 addresses are used with square brackets for MySQL and MariaDB and allowing the configuration of a non-default port number for the IPv6 address. However, with PostgreSQL, square brackets around IPv6 addresses are not usable, and setting a port is not possible.
Since it was decided to have only a single host field without a separate port number field in Joomla Web Installer (see issue #43902), there is a need to use square brackets to distinguish between the IPv6 host address and a port number.
This PR removes the square brackets somewhere in the middle, after separating a possible port number, but before continuing with PostgreSQL:
Testing Instructions
🚧 DRAFT For the moment together with and will be added to joomla-cypress-36
Documentation Changes Required
TODO