Skip to content

[3.x-dev] New methods to get bool and string session variables#294

Closed
richard67 wants to merge 1 commit intojoomla-framework:3.x-devfrom
richard67:3.0-dev-session-variables
Closed

[3.x-dev] New methods to get bool and string session variables#294
richard67 wants to merge 1 commit intojoomla-framework:3.x-devfrom
richard67:3.0-dev-session-variables

Conversation

@richard67
Copy link
Contributor

@richard67 richard67 commented Dec 21, 2023

Pull Request for new feature

Related to PR #293 .

Related CMS issues joomla/joomla-cms#39479 and joomla/joomla-cms#41156 .

Summary of Changes

This Pull Request (PR) adds 2 new methods to get the values of session variables to the database drivers, one for boolean and one for string session variables.

This could be extended in future by methods to get array session variables like e.g. sql_mode.

For integer session variables this would not be easily applicable because the value range of integer session variables at least on MySQL and MariaDB exceeds everything which can be handled in PHP with integer or float variables without any maths extension. But they can be handled like strings.

This PR will allow Joomla CMS to show the values of the sql_big_selects and max_join_size variables in its system information.

The corresponding PR for the CMS is joomla/joomla-cms#42559 .

Testing Instructions

Will be added soon.

Documentation Changes Required

None.

@richard67
Copy link
Contributor Author

Meanwhile I was able to identify the critical SQL query in the CMS core which causes the issue with "max_join_size", and a pull request is ready for being merged: joomla/joomla-cms#42576 . So for the CMS core the issue will be solved, and it will not need the changes from this PR here.

As it has turned out, the SQL error happens only on MariaDB but not on MySQL databases. It seems they handle the "max_join_size" differently.

That makes me think that the change proposed with this PR here is not really necessary, so I close it.

@richard67 richard67 closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments