Fixing default values from getTableColumns#180
Merged
wilsonge merged 4 commits intojoomla-framework:2.0-devfrom Aug 11, 2019
Merged
Fixing default values from getTableColumns#180wilsonge merged 4 commits intojoomla-framework:2.0-devfrom
wilsonge merged 4 commits intojoomla-framework:2.0-devfrom
Conversation
Merged
Contributor
|
Can you rebase this onto 2.0-dev please now |
Contributor
Author
|
There you go. |
Contributor
|
Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stems from an error thrown by the tests in this PR: joomla/joomla-cms#25761
The getTableColumns() method for Postgres returns some funky data for at least the datetime column type. The default for the given column is '1970-01-01 00:00:00' (as wrong as that is as a null value...), but the default value given from getTableColumns (and subsequently used by JTable) is "'1970-01-01 00:00:00'::timestamp without time zone". This tries to fix that. I also think that the null-code around line 228 has to be moved up like I did, otherwise it wont do anything... With this code, the PR mentioned above, passes.