[4.0] Use HttpFactory to fetch zip file from CI server #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
changed the title
roland-d
requested changes
Mar 21, 2020
Collaborator
roland-d
left a comment
roland-d
left a comment
There was a problem hiding this comment.
@richard67 Can you please rebase this to the master branch as the master branch is now the working branch for Patch Tester 4. Thank you.
| $result = null; | ||
| } | ||
|
|
||
| if ($result === null || ($result->code != 200 && $result->code != 310)) |
Collaborator
There was a problem hiding this comment.
@richard67 Please use the functions instead of the magic getter. So $result->getStatusCode()
| Folder::create($tempPath); | ||
| file_put_contents($zipPath, fopen($serverZipPath, "r")); | ||
| // Assign to variable to avlod PHP notice "Indirect modification of overloaded property" | ||
| $content = $result->body; |
Collaborator
There was a problem hiding this comment.
@richard67 Please use (string) $result->getBody() instead of the magic getter
Author
|
@roland-d Will do so, but give me a bit time. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #233 .
Summary of Changes
See the title.
Testing Instructions
Verify that applying and reverting a PR which requires the CI server (e.g. PR joomla/joomla-cms#26845) still works without issues.
Important note: Do NOT test with a PR which changes composer dependencies like e.g. PR joomla/joomla-cms#26440. There happens a fatal error which seems to be caused by missing or removed 3rd party libraries. This is the case with and without this PR here, am investigating further.
You need the latest patchtester release https://github.com/joomla-extensions/patchtester/releases/tag/4.0.0-beta2 plus the changes from PR's merged after that release + the changes of this PR here.
You can download a patched patchtester 4.0.0-beta2 with all these changes here: https://test5.richard-fath.de/com_patchtester_4.0.0.beta3-dev-3.zip. This package also contains the change from PR #246 .