Popover timeout handlers #77
Conversation
Refactor .display() by extracting 3 functions
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 30.87% 35.95% +5.08%
==========================================
Files 45 45
Lines 1341 1346 +5
Branches 316 314 -2
==========================================
+ Hits 414 484 +70
+ Misses 927 862 -65
Continue to review full report at Codecov.
|
| $element.on('mouseenter', display); | ||
| $element.off('mouseleave', mouseOut); |
There was a problem hiding this comment.
add these to $scope.$on('$destroy' ?
Other codeclimate changes
Format demo page
Remove .removeGroup() from PopoverRegistry
|
Now addresses #57. Still has an issue in this area. Also cleaned up some issues. Planning to resolve more tomorrow. |
|
More unit tests, any e2e tests would be awesome here |
|
+1 for tests I got distracted improving the code cov score. |
Refactor popover dom creation
|
Got stuck on testing mouseout closing popovers in protractor. If you have any hints, let me know? Moving to unit testing for now. |
|
More info on doing that here: |
Add specs for PositionHelper, have coverage now need to pass
Add middle to constants Update specs to pass
Update order of dependency injections
|
I think I'm done here. I'd like to get to 💯 but all checks are passing and I'm ready to move on and resolve these two issues. |
Addresses #13.