Skip to content

Updated jQuery implementation to use some real common-place best practices #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated jQuery implementation to use some real common-place best practices #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 33 additions & 18 deletions public/js/jquery/dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,41 +7,56 @@
var pluginName = 'dashboard';

$.fn[pluginName] = function (options) {
var args = arguments;
this.each(function () {
var _this = $.data(this, pluginName);
if (typeof options === 'string') {
_this[options].apply(_this, {});
}
else {
return $.data(this, pluginName, new Dashboard(this, $.extend(true, {}, options)));
if (_this && typeof options === 'string') {
_this[options].apply(_this, Array.prototype.slice.call(args, 1));
}
else if (_this && typeof options === 'object') {
_this['update'].apply(_this, [ options ]);
}
else if (!_this) {
return $.data(this, pluginName, new Dashboard(this, $.extend(true, {}, options)));
}
});
};

var Dashboard = function (el, options) {

this.$element = $(el);
this.$element = $(document.createElement('div')).appendTo($(el));
this.options = options;
this.render();
};

Dashboard.prototype.update = function () {
Dashboard.prototype.update = function (options) {
if(options) {
this.options = options;
}
this.options.factory.update();
this.render();
};

Dashboard.prototype.render = function () {

var data = this.options.factory.data;

var $wrapper = $('<div></div>');
for (i = 0; i < data.length; i++) {
$wrapper
.append($('<div class="item" style="background-color:' + data[i].color + ';"></div>')
.append('<label>' + data[i].val + '%</label>')
);
}
this.$element.empty().append($wrapper);

var $el = this.$element;
var dif = data.length - $el.children().length;

// diff
if(dif < 0) { $el.children('.item:lt(' + (-1*dif) + ')').remove(); }
if(dif > 0) { for(var i=0;i<dif;i++){ $el.append($(document.createElement('div')).addClass('item').data({ color: '', val: -1 }).append($(document.createElement('label')))); }}

// update
var dl = 0;
$el.children().each(function() {
var d = data[dl++];
var $t = $(this); var td = $t.data(); var c = 0;
if(td.color !== d.color){ c = 1; $t.css({'background-color': d.color}); }
if(td.val === -1 || td.val != d.val){ c = 1; $t.children('label').text(d.val + '%'); }
if(c === 1) {$t.data(d);}
});

};

})(jQuery, window, document);
46 changes: 31 additions & 15 deletions public/v1/js/jquery/dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,38 +7,54 @@
var pluginName = 'dashboard';

$.fn[pluginName] = function (options) {
var args = arguments;
this.each(function () {
var _this = $.data(this, pluginName);
if (typeof options === 'string') {
_this[options].apply(_this, {});
}
else {
return $.data(this, pluginName, new Dashboard(this, $.extend(true, {}, options)));
if (_this && typeof options === 'string') {
_this[options].apply(_this, Array.prototype.slice.call(args, 1));
}
else if (_this && typeof options === 'object') {
_this['update'].apply(_this, [ options ]);
}
else if (!_this) {
return $.data(this, pluginName, new Dashboard(this, $.extend(true, {}, options)));
}
});
};

var Dashboard = function (el, options) {

this.$element = $(el);
this.$element = $(document.createElement('div')).appendTo($(el));
this.options = options;
this.render();
};

Dashboard.prototype.update = function () {
Dashboard.prototype.update = function (options) {
if(options) {
this.options = options;
}
this.options.factory.update();
this.render();
};

Dashboard.prototype.render = function () {

var data = this.options.factory.data;

var $wrapper = $('<div></div>');
for (i = 0; i < data.length; i++) {
$wrapper.append('<div class="item" style="background-color:' + data[i] + ';"></div>');
}
this.$element.empty().append($wrapper);

var $el = this.$element;
var dif = data.length - $el.children().length;

// diff
if(dif < 0) { $el.children('.item:lt(' + (-1*dif) + ')').remove(); }
if(dif > 0) { for(var i=0;i<dif;i++){ $el.append($(document.createElement('div')).addClass('item').data({ color: '' })); }}

// update
var dl = 0;
$el.children().each(function() {
var d = data[dl++];
var $t = $(this); var td = $t.data();
if(td !== d){ $t.css({'background-color': d}); $t.data(d); }
});

};

})(jQuery, window, document);