-
Notifications
You must be signed in to change notification settings - Fork 432
Rewrite of adjustment methods and a some other stuff #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…iling C files) to .gitignore Signed-off-by: Mattias Andrée <[email protected]>
…i method under X by (sloopyly) translating the calls to RandR calls Signed-off-by: Mattias Andrée <[email protected]>
…ons when all monitors can have individual gamma corrections, remove it Signed-off-by: Mattias Andrée <[email protected]>
… that it can be accessed from elsewhere, and make the compile-time configurable Signed-off-by: Mattias Andrée <[email protected]>
|
@jonls Lets move the discussion into its proper issue. |
…, and make elevation constants compile-time configurable Signed-off-by: Mattias Andrée <[email protected]>
|
@jonls I have split out 2 independent minor pull requests, and one pull request — #86 — with some commits that are mutually independent, parts of that pull request will be needed for this pull request. |
…nd -m Signed-off-by: Mattias Andrée <[email protected]>
…fill for using it Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
…lay) that has a matching name Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
…unction Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
…name Signed-off-by: Mattias Andrée <[email protected]>
…gamma-common. When compiling, disable all other methods until they too have been rewritten to use gamma-common. Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
|
This pull request does too much at the same time so I'm closing this for now. I'll take a closer look at the pull requests that were split up. |
Sorry for making a huge monolithic patch, but it was required for my workflow.
This patch merges pull request #60, as it was needed for testing gamma-w32gdi.c
I also took the liberty of implementing issue #59.
As mentioned in #54 it should be possible to use multiple displays and multiple
adjustment methods. This patch allows for multiple displays concurrent, and
can easily (by my estimation) be rewritten to allow for multiple concurrent
adjustment methods. It also makes it easy for redshift-dbus (when it gets added)
to control the monitors individually. Additionally, it supports using lookup tables
both before and efter the standard adjustments have been applied. It does not
however yet provide any functions to ease this for redshift-dbus.
To allow the display to be selected from the command line I also change
the adjustment method option delimiter from
:to,, as:delimits thehost and the display index as well as appears in IPv6 addresses. For
consistency I also make this change for the provider method. And in my
opinion the arguments are now easier to read because of this.
I also put
crtcbeforescreenin the RandR method's help output, becauseit is more probable that the user is intereseted in selection CRTC than screen.
Further, it is now possible to use
crtc=all,screen=allandcard=all.It also reimplements pull request #49, and pull request #47 with the calibrations
being applyed absolutely last (after the lookup tables mentioned in the previous
paragraph.) Further it reimplements pull request #44.
It obsoletes pull request #29 by lettings the brightness limits be configurable at
compile time, with or without a maximum value. It also does this for gamma.
TRANSITION_LOWandTRANSITION_HIGHcan also be configured atcompile time.
This patch also makes it easy for DBus client to implement the gamma adjustment
suggesting in issue #10, by having one addition gamma parameter in the adjustment
settings.
In addition to all this, only a select few warnings available in GCC will now
generate any warnings. And all adjustment method have been rewritten to
share a common base code.