Use separate arguments instead of colon for option delimiting in -l and -m #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd -m Signed-off-by: Mattias Andrée <[email protected]>
Signed-off-by: Mattias Andrée <[email protected]>
Owner
|
@maandree Do you have the reference for the previous discussion? I can't seem to find it right now. |
Owner
|
Found it: #81 |
Owner
|
I'm not happy about completely changing the way the command line options work in a minor release but I understand that this would be useful for handling individual monitor settings?. Do you think we can handle the settings of the monitors through the configuration file entirely so we don't have to apply this change yet? |
Contributor
Author
|
We don't have to change this yet. I think it should be held until version 2.0 that I think should offer full support for multiple monitors, multiple display and multiple adjustment methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed way back. Colon is problematic in -m, and separate arguments is a better solution that will not cause problems in the future. The same change is applied -l, so they work in the same way.